ref(tracemetrics): Reduce analytic events firing #102972
Merged
+12
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need to update them to only fire once per dep updates, and not on empty content.
github-actions
bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Bug: Analytics: Inconsistent Empty Data Events
The aggregate mode analytics in useMetricsPanelAnalytics doesn't check for empty dataScanned before firing, while the samples mode does. Since both modes use the same dataScanned variable from metricSamplesTableResult and send it in analytics, this creates inconsistent behavior where aggregate mode fires analytics events with empty data even when samples mode correctly prevents them.
static/app/views/explore/hooks/useAnalytics.tsx#L784-L787
sentry/static/app/views/explore/hooks/useAnalytics.tsx
Lines 784 to 787 in 145c1ba
narsaynorath
approved these changes
Nov 7, 2025
Jesse-Box
pushed a commit
that referenced
this pull request
Nov 12, 2025
### Summary Need to update them to only fire once per dep updates, and not on empty content.
andrewshie-sentry
pushed a commit
that referenced
this pull request
Nov 13, 2025
### Summary Need to update them to only fire once per dep updates, and not on empty content.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Need to update them to only fire once per dep updates, and not on empty content.